Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: replace philips-software/app-token-action by actions/create-github-app-token #507

Merged
merged 1 commit into from
Jul 17, 2024
Merged

ci: replace philips-software/app-token-action by actions/create-github-app-token #507

merged 1 commit into from
Jul 17, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Jul 17, 2024 •
edited
Loading

Pull Request

Description of changes

As of philips-software/app-token-action#360 the philips-software/app-token-action is deprecated in favor of actions/create-github-app-token. This change replaces the usage of the former action by the latter.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner July 17, 2024 07:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 15 0 0.05s
✅ DOCKERFILE hadolint 2 0 0.57s
✅ JSON prettier 11 0 0 0.64s
✅ JSON v8r 10 0 4.73s
✅ MARKDOWN markdownlint 8 0 0 1.01s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.2s
✅ REPOSITORY checkov yes no 15.54s
✅ REPOSITORY gitleaks yes no 0.34s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.77s
✅ REPOSITORY secretlint yes no 1.21s
✅ REPOSITORY trivy yes no 6.48s
✅ REPOSITORY trivy-sbom yes no 1.2s
✅ REPOSITORY trufflehog yes no 3.27s
✅ SPELL lychee 48 0 1.07s
✅ YAML prettier 20 0 0 0.97s
✅ YAML v8r 20 0 15.83s
✅ YAML yamllint 20 0 0.4s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@github-actions GitHub Actions
Copy link
Contributor

Test Results

 2 files  ±0   2 suites  ±0   52s ⏱️ -1s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7be191d. ± Comparison against base commit aca9c0c.

@github-actions GitHub Actions
Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:8466b35a662bd1fc95d1b540939fb22ae6bbcc86c5fa1fe1a8ff91796b859e93

OS/Platform Previous Size Current Size Delta
linux/amd64 432.86M 432.87M 17.47K (+0.00%)
linux/arm64 572.09M 572.11M 20.99K (+0.00%)

@rjaegers rjaegers enabled auto-merge July 17, 2024 07:46
@github-actions GitHub Actions
Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:7be07cf2786aa356ba80a27f1d067cc0acb59e461d665d73b67d0887266875ce

OS/Platform Previous Size Current Size Delta
linux/amd64 640.74M 640.77M 28.16K (+0.00%)
linux/arm64 633.10M 633.13M 22.75K (+0.00%)

@rjaegers rjaegers added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 49f838d Jul 17, 2024
25 checks passed
@rjaegers rjaegers deleted the feature/deprecate-app-token-action branch July 17, 2024 17:26
@github-actions GitHub Actions
Copy link
Contributor

Pull Request Report (#507)

Static measures

Description Value
Number of added lines 9
Number of deleted lines 12
Number of changed files 2
Number of commits 1
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 10.3 Hours
Time that was spend on the branch before the PR was created 1.9 Min
Time that was spend on the branch before the PR was merged 10.4 Hours
Time to merge after last review 9.8 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 5.6 Hours
Total time spend in last status check run on PR 5.2 Hours

@github-actions GitHub Actions
Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v5.1.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarisTanyeri BarisTanyeri BarisTanyeri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjaegers @BarisTanyeri